fix grid-absolute
for off-center models
#1049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
absolute-grid
option currently works as intended when models are off-center vertically (in the up direction) but not when they are off-center "sideways" (along the grid plane), see example below:This PR changes the behavior to the following:
axes are still in the same position at the origin, but the actor and fading radius of the grid are centered below the model.
There is still room for improvement, for example if the model is very far from the origin the axes may not be visible at all (outside of radius), solving that would require more involved framing/fading patterns of the grid plane.
This fix should at least make the feature not broken anymore.