Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python wheel versioning #1011

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Fix python wheel versioning #1011

merged 2 commits into from
Dec 28, 2023

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Sep 30, 2023 •
edited
Loading

Fix: #1009

@mwestphal
Copy link
Contributor Author

Doesnt work as expected :/

@Meakk
Copy link
Member

Meakk commented Sep 30, 2023

There's more to do, see https://scikit-build-core.readthedocs.io/en/latest/configuration.html#dynamic-metadata

@Meakk
Copy link
Member

Meakk commented Sep 30, 2023

Adding metadata.version.provider = "scikit_build_core.metadata.setuptools_scm" should be enough tho.

@mwestphal mwestphal force-pushed the fix_python_wheel_versioning branch from b3687cb to ccd7d4f Compare December 28, 2023 13:46
@github-actions GitHub Actions
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@mwestphal mwestphal changed the base branch from release to master December 28, 2023 13:47
@mwestphal mwestphal requested a review from Meakk December 28, 2023 13:48
@mwestphal mwestphal force-pushed the fix_python_wheel_versioning branch from ccd7d4f to 420e2ed Compare December 28, 2023 13:49
@mwestphal mwestphal force-pushed the fix_python_wheel_versioning branch from 420e2ed to 407529b Compare December 28, 2023 14:27
@mwestphal mwestphal merged commit f658993 into f3d-app:master Dec 28, 2023
45 checks passed
mwestphal added a commit that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request #1011 from mwestphal/fix_python_wheel_versioning
59c84e0 
Fix python wheel versioning
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request f3d-app#1011 from mwestphal/fix_python_wheel_versi…
7c0303c 
…oning

Fix python wheel versioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python wheel name should be improved
2 participants
@mwestphal @Meakk