Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework background options naming #918

Closed
Tracked by #1243
mwestphal opened this issue Jul 15, 2023 · 12 comments · Fixed by #1801
Closed
Tracked by #1243

Rework background options naming #918

mwestphal opened this issue Jul 15, 2023 · 12 comments · Fixed by #1801
Assignees
Labels
type:enhancement New feature or request
Milestone

Comments

@mwestphal
Copy link
Contributor

mwestphal commented Jul 15, 2023

Describe the bug
Background options for F3D are named a bit wldly, it would be nice to rename them on a major version change

** Current names**

  1. no-background -> AppOptions
  2. bg-color -> render.background.color
  3. hdri -> render.background.hdri
  4. blur-background -> render.background.blur
  5. blur-coc -> render.background.blur.coc
@mwestphal mwestphal added this to the 3.0.0 milestone Jul 15, 2023
@mwestphal
Copy link
Contributor Author

mwestphal commented Jul 15, 2023

Suggestions:

  1. background-none -> AppOptions
  2. background-color -> render.background.color
  3. hdri -> render.background.hdri.file
  4. background-blur -> render.background.blur.enable
  5. backgground-blur-coc -> render.background.blur.coc

Bonus:

  1. hdri-hide -> render.background.hdri.hide

@mwestphal
Copy link
Contributor Author

wdyt @Meakk @snoyer ?

@Da3n0n
Copy link

Da3n0n commented Jul 15, 2023

speaking of BG Color is there a way to currently set the default background color of the Viewport for every file that opened in f3d Permanently ? :D

@Da3n0n
Copy link

Da3n0n commented Jul 15, 2023

or a default hdri that is loaded with every file thats oepened would be nice aswell :D

@mwestphal
Copy link
Contributor Author

You can do that easily using config files , see this: https://f3d.app/doc/user/CONFIGURATION_FILE.html

@Da3n0n
Copy link

Da3n0n commented Jul 18, 2023

thank you so much never copped this , really good stuff :D :P still think would be nice to have option for changing constant 3 vector in side f3d windows or even bg color black to white 0>1 with adjustment like light increase and decrease but for BG color :P

@mwestphal
Copy link
Contributor Author

constant 3 vector in side f3d windows

What do you mean ?

even bg color black to white 0>1 with adjustment like light increase and decrease but for BG color

Interesting idea

Could you open dedicated issues for that ? I'm afraid it's not related to options naming.

@Da3n0n
Copy link

Da3n0n commented Jul 19, 2023

@mwestphals sorry i didnt make it clear i will open a new issue and put the clarification with it there as its related to the BG color aswell and similar idea.

@mwestphal
Copy link
Contributor Author

Partially addressed in #932

@mwestphal
Copy link
Contributor Author

mwestphal commented Aug 2, 2023

Remaining options to rename:

** Current names**

  1. bg-color -> background-color
  2. blur_coc -> blur.coc

@mwestphal mwestphal added the help wanted Please help with this issue! label Jan 7, 2024
@mwestphal mwestphal added type:enhancement New feature or request and removed help wanted Please help with this issue! labels Jan 26, 2024
@mwestphal mwestphal added this to F3D Feb 3, 2024
@mwestphal mwestphal removed this from the 3.0.0 milestone Feb 3, 2024
@mwestphal mwestphal moved this to To do in F3D Feb 10, 2024
@mwestphal mwestphal added this to the 3.0.0 milestone Jul 5, 2024
@mwestphal
Copy link
Contributor Author

--comp -> --coloring-component

@mwestphal mwestphal self-assigned this Dec 4, 2024
@mwestphal
Copy link
Contributor Author

interactor.axis -> ui.axis

@github-project-automation github-project-automation bot moved this from To do to Done in F3D Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants