Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F3D Web first render is incorrectly lit #1506

Closed
Tracked by #1243
mwestphal opened this issue Jun 30, 2024 · 5 comments
Closed
Tracked by #1243

F3D Web first render is incorrectly lit #1506

mwestphal opened this issue Jun 30, 2024 · 5 comments
Assignees
@Meakk
Labels
source:F3DWeb
Milestone
3.0.0

Comments

@mwestphal
Copy link
Contributor

Describe the bug
F3D Web first render is incorretly lit

To Reproduce
Steps to reproduce the behavior:

  1. got to https://f3d.app/web
  2. Load a file
  3. FIle is not correctly lit
  4. Move camera around
  5. Ligthing is corrected
Peek.2024-06-30.18-42.mp4

Expected behavior
Correct lighting right away

Additional context
occlusion texture generation is not updated for some reason, related to SSOA, better to reproduce in python if possible to check if this is WASM specific
@mwestphal mwestphal added this to F3D Jun 30, 2024
@mwestphal mwestphal moved this to Investigate in F3D Jun 30, 2024
@Meakk Meakk added this to the 3.0.0 milestone Jul 1, 2024
@mwestphal mwestphal changed the title F3D Web first render is incorretly lit F3D Web first render is incorrectly lit Jul 4, 2024
@snoyer snoyer mentioned this issue Jul 13, 2024
Open
This was referenced Jul 13, 2024
Open
Closed
@mwestphal
Copy link
Contributor Author

This seems related to SSAO

@mwestphal
Copy link
Contributor Author

First render of f3d.vtp:

a

Then it looks perfect after:

a

@snoyer
Copy link
Contributor

snoyer commented Jul 31, 2024

first render looks like missing normals as per #1553

@Meakk
Copy link
Member

Meakk commented Aug 21, 2024

fixed here: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11417

@Meakk Meakk self-assigned this Aug 21, 2024
@Meakk Meakk moved this from Investigate to In progress in F3D Aug 21, 2024
@Meakk Meakk moved this from In progress to In review in F3D Aug 21, 2024
@Meakk
Copy link
Member

Meakk commented Aug 23, 2024

Fix by updating VTK in f3d-app/f3d-docker-images#18

@Meakk Meakk closed this as completed Aug 23, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in F3D Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Meakk Meakk

Labels
source:F3DWeb
Projects
F3D
Status: Done
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@snoyer @mwestphal @Meakk