-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault on opening gltf without textures #1479
Comments
Could you share example.gltf ? |
It isn't any specific file. For instance, take
And if you remove any of these, or the entire folder, i.e. make uri no longer as files do not exist, it causes segfault. It probably doesn't check files before loading them. I've attachied zips of 2 examples (couldn't upload as single file due to 25MB upload limit): |
|
Complete fix will require to work on the importer API: #653 |
Fixed in VTK thanks for https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11267 Need a bit more work to integrate in F3D |
Update VTK to get fixes needed for: - #1479 - Stability issues with GLTF
fixed by #1512 |
Describe the bug
gltf files contain list of images/textures and when it is opened without these images in the path f3d segfaults.
It probably happens with other file formats, but I haven't tested them.
Here's the stack trace:
To Reproduce
Steps to reproduce the behavior:
f3d example.gltf
Expected behavior
Either generic error message like "Error opening gltf file" or better yet "Error loading texture TEXTURE_PATH required by GLTF_PATH: file doesn't exist"
System Information:
F3D Information
Paste the content of
f3d --version
:Additional context
It happens in libvtk which (if I understand correctly) is a dependency, so to fix we need to read these texture paths (are they already read/available somewhere?) from the gltf file and check that they exist before calling libvtk functions.
The text was updated successfully, but these errors were encountered: