Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49] common-kafka 모듈에 fat jar 적용 #50

Merged
merged 16 commits into from
Feb 2, 2025
Merged

Conversation

sssukho
Copy link
Collaborator

@sssukho sssukho commented Jan 26, 2025

기존에 java-library plugin 을 이용한 api 방식으로 common-kafka 모듈을 참조했으나,
common-kafka 모듈을 fat jar 빌드하고 이를 implementation 으로 참조하는 방식으로 개선하였습니다.

@sssukho sssukho added the enhancement New feature or request label Jan 26, 2025
@sssukho sssukho requested a review from f-lab-lyan January 26, 2025 22:06
@sssukho sssukho self-assigned this Jan 26, 2025
@sssukho sssukho linked an issue Jan 26, 2025 that may be closed by this pull request
# Conflicts:
#	bp-app-api/build.gradle
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/config/WebSecurityConfiguration.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/ErrorResponseMessage.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/ResponseMessage.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/auth/EmailCertificationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/auth/EmailCertificationVerificationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/auth/EmailDuplicatedRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/auth/EmailDuplicatedResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/image/PreSignedGetUrlResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/image/PreSignedPutUrlResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/member/UserRoleMemberRegistrationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/member/UserRoleMemberRegistrationResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/review/FindReviewListRequestParameters.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/review/ReviewFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/review/ReviewListFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/shop/ShopDetailFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/shop/ShopFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/shop/ShopListFindRequestParameters.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/shop/ShopListFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/shop/ShopRegistrationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/dto/shop/ShopRegistrationResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/exception/GlobalExceptionHandler.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/handler/GlobalExceptionHandler.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/request/auth/EmailCertificationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/request/auth/EmailCertificationVerificationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/request/auth/EmailDuplicatedRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/request/member/UserRoleMemberRegistrationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/request/review/FindReviewListRequestParameters.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/request/shop/ShopListFindRequestParameters.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/request/shop/ShopRegistrationRequest.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/ErrorResponseMessage.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/ResponseMessage.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/auth/EmailDuplicatedResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/image/PreSignedGetUrlResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/image/PreSignedPutUrlResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/member/UserRoleMemberRegistrationResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/review/ReviewFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/review/ReviewListFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/shop/ShopDetailFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/shop/ShopFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/response/shop/ShopListFindResult.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/service/AuthService.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/service/FacilityService.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/service/OperationCategoryService.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/service/OperationService.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/service/ReservationService.java
#	bp-app-api/src/main/java/com/beautify_project/bp_app_api/service/ShopFacilityService.java
#	bp-app-api/src/main/java/com/bp/app/api/BpAppApiApplication.java
#	bp-app-api/src/main/java/com/bp/app/api/bean/ImageProviderBean.java
#	bp-app-api/src/main/java/com/bp/app/api/config/WebSecurityConfiguration.java
#	bp-app-api/src/main/java/com/bp/app/api/config/properties/NaverCloudPlatformObjectStorageConfigProperties.java
#	bp-app-api/src/main/java/com/bp/app/api/config/properties/StorageConfig.java
#	bp-app-api/src/main/java/com/bp/app/api/controller/AuthController.java
#	bp-app-api/src/main/java/com/bp/app/api/controller/ImageController.java
#	bp-app-api/src/main/java/com/bp/app/api/controller/MemberController.java
#	bp-app-api/src/main/java/com/bp/app/api/controller/ReviewController.java
#	bp-app-api/src/main/java/com/bp/app/api/controller/ShopController.java
#	bp-app-api/src/main/java/com/bp/app/api/enumeration/ShopSearchType.java
#	bp-app-api/src/main/java/com/bp/app/api/exception/BpCustomException.java
#	bp-app-api/src/main/java/com/bp/app/api/exception/GlobalExceptionHandler.java
#	bp-app-api/src/main/java/com/bp/app/api/provider/image/ImageProvider.java
#	bp-app-api/src/main/java/com/bp/app/api/provider/image/NCPImageProvider.java
#	bp-app-api/src/main/java/com/bp/app/api/request/auth/EmailCertificationRequest.java
#	bp-app-api/src/main/java/com/bp/app/api/request/auth/EmailCertificationVerificationRequest.java
#	bp-app-api/src/main/java/com/bp/app/api/request/auth/EmailDuplicatedRequest.java
#	bp-app-api/src/main/java/com/bp/app/api/request/member/UserRoleMemberRegistrationRequest.java
#	bp-app-api/src/main/java/com/bp/app/api/request/review/FindReviewListRequestParameters.java
#	bp-app-api/src/main/java/com/bp/app/api/request/shop/ShopListFindRequestParameters.java
#	bp-app-api/src/main/java/com/bp/app/api/request/shop/ShopRegistrationRequest.java
#	bp-app-api/src/main/java/com/bp/app/api/response/ErrorResponseMessage.java
#	bp-app-api/src/main/java/com/bp/app/api/response/ResponseMessage.java
#	bp-app-api/src/main/java/com/bp/app/api/response/auth/EmailDuplicatedResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/image/PreSignedGetUrlResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/image/PreSignedPutUrlResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/member/UserRoleMemberRegistrationResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/review/ReviewFindResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/review/ReviewListFindResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/shop/ShopDetailFindResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/shop/ShopFindResult.java
#	bp-app-api/src/main/java/com/bp/app/api/response/shop/ShopListFindResult.java
#	bp-app-api/src/main/java/com/bp/app/api/service/MemberService.java
#	bp-app-api/src/main/java/com/bp/app/api/service/ReviewService.java
#	bp-app-api/src/main/java/com/bp/app/api/service/ShopOperationService.java
#	bp-app-api/src/main/java/com/bp/app/api/service/ShopService.java
#	bp-app-api/src/main/resources/application-local.yml
#	bp-app-api/src/main/resources/application-prod.yml
#	bp-app-api/src/main/resources/application-test.yml
#	bp-app-api/src/test/java/com/beautify_project/bp_app_api/integration/MemberIntegrationTest.java
#	bp-app-api/src/test/java/com/beautify_project/bp_app_api/integration/ShopServiceRepositoryIntegrationTest.java
#	bp-app-api/src/test/java/com/beautify_project/bp_app_api/service/ReviewServiceTest.java
#	bp-app-api/src/test/java/com/beautify_project/bp_app_api/service/ShopServiceTest.java
#	bp-app-api/src/test/java/com/bp/app/api/controller/ImageControllerTest.java
#	bp-app-api/src/test/java/com/bp/app/api/controller/ReviewControllerTest.java
#	bp-app-api/src/test/java/com/bp/app/api/controller/ShopControllerTest.java
#	bp-app-api/src/test/java/com/bp/app/api/integration/AuthIntegrationTest.java
#	bp-app-api/src/test/java/com/bp/app/api/integration/MemberAdapterIntegrationTest.java
#	bp-app-api/src/test/java/com/bp/app/api/integration/MemberIntegrationTest.java
#	bp-common/build.gradle
#	bp-domain-mysql/src/main/java/com/beautify_project/bp_mysql/repository/EmailCertificationRepository.java
#	bp-domain-mysql/src/main/java/com/beautify_project/bp_mysql/repository/MemberRepository.java
#	bp-domain-mysql/src/main/java/com/bp/domain/mysql/entity/Member.java
#	bp-domain-mysql/src/main/java/com/bp/domain/mysql/repository/EmailCertificationRepositoryProxy.java
#	bp-domain-mysql/src/main/java/com/bp/domain/mysql/repository/MemberAdapterRepository.java
#	bp-domain-mysql/src/main/resources/mysql-config/application-local.yml
#	bp-security/src/main/java/com/beautify_project/bp_security/config/WebSecurityConfiguration.java
#	settings.gradle
Copy link
Collaborator

@f-lab-lyan f-lab-lyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 👍

@sssukho sssukho merged commit c186f56 into feature/47 Feb 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common-kafka 모듈에 fat jar 적용
2 participants