Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check .github/ghstack_direct to decide if using direct by default #258

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

ezyang
Copy link
Owner

@ezyang ezyang commented Aug 10, 2024

Signed-off-by: Edward Z. Yang [email protected]

[ghstack-poisoned]
@ezyang
Copy link
Owner Author

ezyang commented Aug 10, 2024

ezyang added a commit that referenced this pull request Aug 10, 2024
Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: ee5a2fdd0ec216a26495b567c9b2258590e842f2
ghstack-comment-id: 2282269800
Pull Request resolved: #258
Copy link

@kirklandsign kirklandsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That's a useful feature!

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 12, 2024
Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: 8fb9ddaad49e1cc978e7c931979b85b533963883
ghstack-comment-id: 2282269800
Pull Request resolved: #258
@ezyang
Copy link
Owner Author

ezyang commented Aug 12, 2024

@kirklandsign Do you have an opinion about whether or not I should flip the default so --direct by default, and the other behavior only if there's a different signal file?

@kirklandsign
Copy link

@kirklandsign Do you have an opinion about whether or not I should flip the default so --direct by default, and the other behavior only if there's a different signal file?

To our use case checking .github/ghstack_direct without flipping the default value works, and it causes minimal behavior changes to users who are already using ghstack in other repos like pytorch/pytorch otherwise.

@ezyang ezyang merged commit a53b4fe into master Aug 13, 2024
16 checks passed
@ezyang ezyang deleted the gh/ezyang/19/head branch August 13, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants