IBX-154: Allowed to define if the alternative text for image field is required (2.5) #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adamwojs
commented
Jun 16, 2021
adamwojs
commented
alongosz
approved these changes
Jun 17, 2021
| @@ -38,13 +38,18 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| TextType::class, | |||
| [ | |||
| 'label' => /** @Desc("Alternative text") */ 'content.field_type.ezimage.alternative_text', | |||
| 'required' => false, | |||
| 'required' => $options['is_alternative_text_required'], | |||
There was a problem hiding this comment.
Is it guaranteed that the key is present in the array?
There was a problem hiding this comment.
As part of configureOptions, yes.
setDefaults implies that the field is required, at the same time providing a default value.
Steveb-p
approved these changes
Jun 17, 2021
ViniTou
approved these changes
Jun 17, 2021
piotrbisaga
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.