Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-461: Fixed roles with deleted limitations #347

Merged
merged 4 commits into from
Jun 16, 2021
Merged

IBX-461: Fixed roles with deleted limitations #347

merged 4 commits into from
Jun 16, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jun 7, 2021

Question Answer
JIRA issue IBX-461
Type bug
BC breaks no
Tests pass yes
Doc needed no

Fallbacks have been added to properly handle deleted Limitations, especially Location one.

@barw4 barw4 self-assigned this Jun 7, 2021
@barw4 barw4 requested a review from a team June 7, 2021 15:12
Steveb-p
Steveb-p approved these changes Jun 14, 2021
View reviewed changes
Copy link

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a "nitpicky" remark. I see a similar code used elsewhere.

tests/RepositoryForms/Limitation/DataTransformer/UDWBasedValueModelTransformerTest.php Outdated Show resolved Hide resolved
@tomaszszopinski tomaszszopinski self-assigned this Jun 16, 2021
tomaszszopinski
tomaszszopinski approved these changes Jun 16, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5 & v2.5.20 with patch & diff.

@lserwatka lserwatka merged commit 4840872 into 2.5 Jun 16, 2021
@lserwatka lserwatka deleted the ibx-461-fix-roles-with-deleted-limitations branch June 16, 2021 11:15
@lserwatka
Copy link
Member

You can merge it up now

@barw4
Copy link
Member Author

barw4 commented Jun 16, 2021 •
edited
Loading

Merged into ezplatform-content-forms:
1.2: ezsystems/ezplatform-content-forms@2c90e9c
1.3: ezsystems/ezplatform-content-forms@62ca1a3
master: ezsystems/ezplatform-content-forms@2bf4ce2

Follow up PRs need to be created for v3.

@barw4 barw4 mentioned this pull request Jun 16, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@barw4 @lserwatka @adamwojs @mikadamczyk @Steveb-p @alongosz @webhdx @tomaszszopinski