Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1237: Removed duplicated content tag #3123

Merged
merged 1 commit into from
Oct 12, 2021
Merged

IBX-1237: Removed duplicated content tag #3123

merged 1 commit into from
Oct 12, 2021

Conversation

konradoboza
Copy link
Member

Question Answer
JIRA issue IBX-1237
Type bug
Target eZ Platform version v2.5
BC breaks no

The duplicated tag was wrongly introduced in https://github.com/ezsystems/ezpublish-kernel/pull/3114/files#diff-4e4afd929b7d374bdbb6ca18617eeb1482d209f7eb9493b20b6adafe112f1ea0R129.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@konradoboza konradoboza self-assigned this Oct 12, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@konradoboza
Copy link
Member Author

Since this seems to be a defensive fix: do we involve QA?

@Steveb-p
Copy link
Contributor

@konradoboza no need. The change is obvious and there is no chance of anything breaking.

It would be a waste of time.

@adamwojs adamwojs merged commit baea4c5 into 7.5 Oct 12, 2021
@adamwojs adamwojs deleted the ibx-1237-duplicated-content-tag branch October 12, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@konradoboza konradoboza

Labels
Bug Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konradoboza @Steveb-p @adamwojs