EZP-32361: Fixed Subtree copying when child is invisible #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barw4 CI is failing here. |
alongosz
approved these changes
May 26, 2021
adamwojs
approved these changes
May 27, 2021
Steveb-p
approved these changes
May 27, 2021
Comment on lines
+2558
to
+2563
| self::assertEquals(count($expected), count($actual)); | ||
|
|
||
| foreach ($actual as $key => $properties) { | ||
| self::assertEquals($expected[$key]['hidden'], $properties['hidden']); | ||
| self::assertEquals($expected[$key]['invisible'], $properties['invisible']); | ||
| } |
There was a problem hiding this comment.
In general usage of self::assertSame is preferred. It's similar to using == vs === - if there is no reason for non-strict comparison, strict should be used.
kacper-wieczorek-ibexa
approved these changes
May 28, 2021
|
You can merge it up. |
|
Merged into: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5TODO:
$ composer fix-cs).