EZEE-1710: Change Selenium version #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
changed the title
|
@vidarl @andrerom If I got everything right this PR should introduce the same changes to ezrobot that were done in ezsystems/ezplatform#203 |
vidarl
requested changes
Aug 31, 2017
docker-compose_behat.yml.template
Outdated
| @@ -9,6 +9,8 @@ selenium: | |||
| - SCREEN_WIDTH=1920 | |||
| - SCREEN_HEIGHT=1080 | |||
| - SCREEN_DEPTH=24 | |||
| # Because of: https://github.com/elgalu/docker-selenium/issues/20 | |||
| shm_size: 256m | |||
There was a problem hiding this comment.
Indenting is wrong (one space too much)
|
@micszo : Pinging you just in case as we have had quite a few issues with selenium/firefox in the past... Looks fine to me.. Unless there are objections I purpose to merge after weekend ( Monday ). I should be able to dig into ezrobot if it by any chance causes problems |
|
I'm fine with merging it on Monday, there's no rush. |
|
@vidarl thanks. For me it's ok to take it easy. |
andrerom
approved these changes
Sep 4, 2017
vidarl
approved these changes
Sep 4, 2017
|
merged, ezrobot should automatic pull the changes before running the next job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the same changes as in ezsystems/ezplatform#203 to make sure our tests on Jenkins behave the same way as on Travis.
I've set shm_size to 256m, because my local tests showed that 128m is too low (I guess interacting with the Studio editor requires more resources). 256m should be enough.