Add gzip encoding by default #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we do this, it should add to nginx as well if possible Also: We need to adapt Varnish config for this right? EDIT: However unsure how Varnish will behave with this, might be better to document usage of this for the front facing node facing the web, like nginx tsl proxy for instance. Or? |
andrerom
reviewed
Apr 19, 2018
doc/apache2/vhost.template
Outdated
|
|
||
| # Enable gzip encoding | ||
| <IfModule mod_deflate.c> | ||
| AddOutputFilterByType DEFLATE text/css application/x-javascript application/javascript text/javascript text/plain text/html text/xml application/xml |
There was a problem hiding this comment.
Besides lack of config for nginx, should also omit html here as it should not be used in combination with https. (ref: BREACH/CRIME)
There was a problem hiding this comment.
Thanks. I've broken this out with a comment.
peterkeung
force-pushed
the
add_gzip_encoding
branch
from
b323b5c to
adeefd1
Compare
andrerom
pushed a commit
that referenced
this pull request
Mar 18, 2019
|
Closed in favour of #375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page speed best practices means we should add gzip encoding by default
varnish vclShould work by default: https://varnish-cache.org/docs/trunk/users-guide/compression.html