EZP-30513: eZXMLText Migration: ignore nested embeds in the link

[SerheyDolgushev]

Question	Answer
JIRA issue	EZP-30513
Type	Improvement
Target version	1.7
BC breaks	no
Doc needed	no

We found that in some cases there might be nested embed-inline elements inside link in eZ XML Text:

<link node_id="333">some text
  <embed-inline view="embed-inline" size="original" object_id="444"/>
</link>

And it will be converted to invalid RichText:

<link xlink:href="ezlocation://333" xlink:show="none">some text
  <ezembedinline xlink:href="ezcontent://444" view="embed-inline">
    <ezlink xlink:href="ezlocation://333" xlink:show="none"/>
    <ezconfig>
      <ezvalue key="size">original</ezvalue>
    </ezconfig>
  </ezembedinline>
</link>

Such kind embeds need to be ignored.

TODO:

• Implement feature / fix a bug.
• Implement tests and passing ($ composer test)
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review

[vidarl]

Do you know in what scenario the user might got such nested embeds inside links? Are the embeds rendered somehow in legacy? if it is, maybe the embed should be moved before or after the link?

[SerheyDolgushev]

Sorry, not sure what is the best scenario to reproduce this kind of data in legacy. Most likely it was populated by some legacy import scripts.

[SerheyDolgushev]

@mnocon can you please check why tests are failing here?

E: Package 'mysql-server-5.6' has no installation candidate
E: Package 'mysql-client-core-5.6' has no installation candidate
E: Package 'mysql-client-5.6' has no installation candidate

[mnocon]

@SerheyDolgushev see #109

[mnocon]

@SerheyDolgushev #109 is merged, rebasing should help here

[SerheyDolgushev]

@mnocon thanks!

[andrerom]

@vidarl isn't embed-inline a text type inline tag which can be within anything (link, paragraph, bold, custom-inline, ..) ?

@SerheyDolgushev do we have something to convert to instead of removing them?

[SerheyDolgushev]

@andrerom don't think there is any reason to convert this. As the only source for such kind content is custom imports/etc. And most likely such content wasn't displayed properly in the legacy. So most likely it is something which was imported in a wrong way, and nobody noticed it in the legacy. That's why I vote just for skipping it.

[vidarl]

@vidarl isn't embed-inline a text type inline tag which can be within anything (link, paragraph, bold, custom-inline, ..) ?

yes, well. I am not sure if legacy can have it within anything. That is why I asked how legacy rendered this. We might have to move (not delete) it as we do with links inside links:

https://github.com/ezsystems/ezplatform-xmltext-fieldtype/blob/master/lib/FieldType/XmlText/Converter/RichText.php#L422

[andrerom]

@SerheyDolgushev Could you:

• Double check assumptions here and get someone to render the content where you encountered this on the said legacy install?
• Is it ok to go for the approach @vidarl suggests above?

[vidarl]

I tested legacy, and legacy indeed renders both the link and the inline-embed.
It is quite possible to create such markup using simplified xml input. Was not able to do it with OE though

[SerheyDolgushev]

Sorry, so what would be the next steps here? Should we move (but not delete, as @vidarl suggested) those elements?

[vidarl]

Yes, move the embed outside of the link tag so that it is not lost

[vidarl]

Closed this one in favor of #110