Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to extend RichText converter #90

Closed
wants to merge 1 commit into from
Closed

Allow to extend RichText converter #90

wants to merge 1 commit into from

Conversation

SerheyDolgushev
Copy link
Contributor

No description provided.

@andrerom andrerom requested a review from vidarl April 2, 2019 18:12
@andrerom
Copy link
Contributor

Just changing everything to protected is usually a bad idea. Then suddenly we can't change any of it on future bug fixes affecting these parts.

Do you have concrete example of what you need to do here? (high level use case)

@SerheyDolgushev
Copy link
Contributor Author

I made this PR before #92 to achieve similar results. And it can be closed as #92 is merged already.

@andrerom andrerom closed this Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidarl vidarl Awaiting requested review from vidarl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SerheyDolgushev @andrerom