EZP-29846: ezxmltext -> ricktext conversion: Conversion tool skips some ezxmltext rows #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
reviewed
Nov 29, 2018
lib/FieldType/XmlText/Persistence/Legacy/ContentModelGateway.php
Outdated
Show resolved
Hide resolved
…kips some ezxmltext rows
kmadejski
approved these changes
Nov 29, 2018
| @@ -92,18 +92,26 @@ public function getContentTypeFieldTypeUpdateQuery($fromFieldTypeIdentifier, $to | |||
| return $updateQuery; | |||
| } | |||
|
|
|||
| public function getRowCountOfContentObjectAttributes($datatypeString, $contentId) | |||
| /** | |||
| * @param string|array $datatypes One datatype may be provided as string. Multiple datatypes areaccepted as array | |||
There was a problem hiding this comment.
Just a nitpick: areaccepted -> are accepted.
andrerom
approved these changes
Nov 29, 2018
|
Should this target 1.7? |
…kips some ezxmltext rows
|
FYI : fixed in ee587fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes EZP-29846, also reported here : https://github.com/ezsystems/ezplatform-xmltext-fieldtype/issues/60
So the problem was that the different rows was distributed to child processes using
select * from ezcontentobject_attribute where data_type_string='ezxmltext' limit $limit, $offset, which ended badly as data_type_string values where changed from 'ezxmltext' to 'ezrichtext' during conversion.This PR has the quick fix for it. A better quicker solution would be to get ridd of the slower
$offsetapproach all together