Feature to add link from embed tags #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Would you mind adding a test for it too? |
|
Added test in new PR : #85 |
|
Sorry for the delay, I don't have a lot of time and to be honest, I had no idea how to add this kind of test. Thank you for adding it. Hoping this MR could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, when we want to add link on embed image, the result ignores the links attributes (i.e. url, ezlegacytmp-embed-link-target, etc.).
This pull request updates the main xsl file (eZXml2Html5_core.xsl) to add the 'a' tag with its attributes.