Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #82

Merged
merged 3 commits into from
Oct 26, 2018
Merged

UI improvements #82

merged 3 commits into from
Oct 26, 2018

Conversation

vidarl
Copy link
Member

@vidarl vidarl commented Oct 12, 2018

This PR adds:

  • Progress bar to ezxmltext:convert-to-richtext script
  • Outputs non-validating docbook xml (indented) when running ezxmltext:import-xml script using --content-object

The ezxmltext:convert-to-richtext script may run for quite some time on large databases and the lack of progress bar could give the user an impression that it didn't do anything

The output of docbook xml helps user to figure out what is wrong when fixing bad ezxmltext markup

@vidarl vidarl requested review from kmadejski and andrerom October 12, 2018 11:06
@vidarl vidarl changed the title Ui improvements UI improvements Oct 12, 2018
@vidarl
Copy link
Member Author

vidarl commented Oct 12, 2018

Note : Do not merge this PR as long as it is based on db-gateway branch !!

Copy link
Member

@kmadejski kmadejski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, just a small nitpick:

bundle/Command/ConvertXmlTextToRichTextCommand.php Outdated Show resolved Hide resolved
bundle/Command/ConvertXmlTextToRichTextCommand.php Outdated Show resolved Hide resolved
@vidarl vidarl force-pushed the db-gateway branch 2 times, most recently from 298bc5f to cb178a2 Compare October 18, 2018 11:03
@vidarl vidarl changed the base branch from db-gateway to 1.7 October 26, 2018 09:17
@vidarl vidarl merged commit d111132 into 1.7 Oct 26, 2018
@vidarl vidarl deleted the ui-improvements branch October 26, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants