EZP-27308: Remove deprecated usage of Symfony services #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emodric
changed the title
andrerom
approved these changes
Apr 26, 2017
bdunogier
approved these changes
Apr 26, 2017
|
@emodric are you activly using master at the moment, is it ready for v1.1.4 release? Besides this change I see there are some QA tested thirdline issues in there also. |
|
No, but the fixes are interesting, especially the one for the preview, since I think some of our clients ran into that one, one or two times. Master can be tagged with |
|
Ok, @bdunogier I guess we can do an v1.2.0-rc1 and get it tested a bit by community and others. ok with you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service names will become case sensitive in later Symfony versions.