Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure <eztemplate> elements contains <ezcontent> child #113

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

vidarl
Copy link
Member

@vidarl vidarl commented Nov 14, 2019

Question Answer
JIRA issue EZP-31130 : {{ content }} variable not always available in twig template for custom tag
Type Improvement
Target version 1.8
BC breaks no
Doc needed no

This change is to ensure conversion script creates customtags in the same way as admin-ui ( even though the previous behaviour also was also valid schema wise). admin-ui always creates a <ezcontent/> element below eztemplate, even though the custom tags has no content..

eZ Platform version 2.5.6 and earlier will give fatal error on the following twig code for <eztemplate> elements which has no <ezcontent/> sub element:

{{ content|raw }}

See ezsystems/ezplatform-richtext#84 for more info.

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@vidarl vidarl requested review from alongosz and andrerom November 14, 2019 08:29
@andrerom
Copy link
Contributor

@vidarl Feel free to merge and merge up.

@lserwatka lserwatka merged commit 64422b5 into 1.8 Dec 10, 2019
@lserwatka lserwatka deleted the eztemplate_empty_ezcontent_tag branch December 10, 2019 08:28
@lserwatka
Copy link
Member

@vidarl could you merge it up.

@vidarl
Copy link
Member Author

vidarl commented Dec 10, 2019

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants