Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove class parameters #106

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Remove class parameters #106

merged 1 commit into from
Jul 10, 2019

Conversation

emodric
Copy link
Collaborator

@emodric emodric commented Jul 9, 2019

Question Answer
JIRA issue N/A
Type Improvement
Target version master
BC breaks yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@emodric emodric requested review from andrerom and alongosz July 9, 2019 10:03
@emodric emodric merged commit d0bb9ae into master Jul 10, 2019
@emodric emodric deleted the remove_class_params branch July 10, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emodric @andrerom @alongosz