Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated field type tags #105

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Replace deprecated field type tags #105

merged 1 commit into from
Jul 9, 2019

Conversation

emodric
Copy link
Collaborator

@emodric emodric commented Jul 9, 2019

Question Answer
JIRA issue N/A
Type Improvement
Target version master
BC breaks yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@emodric emodric requested review from alongosz and andrerom July 9, 2019 10:03
andrerom
andrerom reviewed Jul 9, 2019
View reviewed changes
lib/settings/storage_engines/legacy/field_value_converters.yml
@@ -7,4 +7,4 @@ services:
ezpublish.fieldType.ezxmltext.converter:
class: "%ezpublish.fieldType.ezxmltext.converter.class%"
tags:
- {name: ezpublish.storageEngine.legacy.converter, alias: ezxmltext, lazy: true, callback: '::create'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this won't break anything (removing the callback)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It was changed to use a normal PHP constructor a while ago.

@emodric emodric merged commit c6a06b7 into master Jul 9, 2019
@emodric emodric deleted the fix_di_tags branch July 9, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emodric @andrerom @alongosz