EZP-30129: Handled bold & italic styles when converting from OE format to DocBook #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
changed the title
alongosz
reviewed
Dec 20, 2019
alongosz
approved these changes
Jan 8, 2020
micszo
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
QA Approved on eZ Platform EE v2.5.8 with diff (also with diff from EZP-30033).
Checked with lists. Also checked underline, strikethrough, subscript, superscript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format coming from copy /paste will often use
<b>and<i>tags, or sometimes also span tags with bold / italic style attribute. This change makes sure to map these cases to the correct docbook tags we support. Solving the linked Word copy / paste issue, as well as improving the code for import use cases from other systems.TODO:
$ composer fix-cs).