Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30906: Removed deprecated templating component integration #66

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Sep 5, 2019

Question Answer
JIRA issue EZP-30906
Bug/Improvement yes
New feature no
Target version master
BC breaks no
Tests pass yes
Doc needed no

main PR:
ezsystems/ezplatform#453

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@alongosz alongosz changed the title EZP-30906: Remove deprecated templating services EZP-30906: Removed deprecated templating services Sep 8, 2019
@ViniTou ViniTou changed the title EZP-30906: Removed deprecated templating services EZP-30906: Removed deprecated templating component integration Sep 9, 2019
@ViniTou ViniTou force-pushed the ezp-30906-remove_deprecated_templating_services branch from fc7883a to 710a606 Compare September 9, 2019 09:24
Copy link
Contributor

@mikadamczyk mikadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this could be a little out of the scope but could we extract

        $this->loaderMock
            ->method('exists')
            ->with($templateName)
            ->willReturn(false);
        $this->templateEngineMock
            ->expects($this->once())
            ->method('getLoader')
            ->willReturn($this->loaderMock);

to private method to simplify and reduce number of lines?

@alongosz alongosz merged commit 4992a3a into master Sep 20, 2019
@alongosz alongosz deleted the ezp-30906-remove_deprecated_templating_services branch September 20, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants