Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30517: Dropped Kernel BC layer and deprecated code #42

Merged
merged 9 commits into from
Jun 4, 2019
Merged

EZP-30517: Dropped Kernel BC layer and deprecated code #42

merged 9 commits into from
Jun 4, 2019

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented May 31, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-30517
Bug/Improvement yes
New feature no
Target version master (2.0) for eZ Platform v3.0
BC breaks yes
Tests pass yes
Doc needed no

This PR drops RichText Kernel BC layer and all code marked as deprecated.

TODO:

  • Drop deprecated Renderer checkContent method.
  • [XSL] Drop deprecated ezembed(inline)/link support.
  • Drop deprecated Renderer renderTag and renderStyle methods.
  • Drop deprecated Validator::validate method.
  • Drop deprecated RichTextFieldValueConverter::create static method.
  • Drop LegacyStorage RichText gateway.
  • Drop ezpublish-kernel RichText BC layer.
  • Add missing throws tag to EzPlatformRichTextExtension::load PhpDoc.
  • Confirm Travis agrees.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@alongosz alongosz added the Improvement New feature or request label May 31, 2019
@alongosz alongosz mentioned this pull request May 31, 2019
Merged
4 tasks
@adamwojs
Copy link
Member

adamwojs commented Jun 3, 2019 •
edited
Loading

Is CI failure related to changelog?

  The service "ezpublish_rest.field_type_processor.ezrichtext" has a dependency on a non-existent service "ezpublish.fieldType.ezrichtext.converter.edit.xhtml5".

@alongosz
Copy link
Member Author

alongosz commented Jun 3, 2019

@adamwojs fixed via ezsystems/ezplatform-rest#9

@alongosz alongosz mentioned this pull request Jun 3, 2019
Merged
3 tasks
@alongosz alongosz mentioned this pull request Jun 3, 2019
Merged
3 tasks
@alongosz alongosz merged commit 855e38f into ezsystems:master Jun 4, 2019
@alongosz alongosz deleted the ezp-30517-drop-deprecated-code branch June 4, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@dew326 dew326 dew326 approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees
No one assigned
Labels
Improvement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alongosz @adamwojs @dew326