EZP-29876: New break lines disappear in Richtext while styled with custom styles #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom styles (unit tests)
adamwojs
requested review from
alongosz,
ViniTou,
mikadamczyk,
webhdx and
Nattfarinn
alongosz
requested changes
Apr 11, 2019
| @@ -657,6 +657,12 @@ | |||
| <xsl:apply-templates select="node()|@*"/> | |||
| </xsl:template> | |||
|
|
|||
| <xsl:template match="docbook:eztemplate[@type='style']/docbook:ezcontent/text()"> | |||
There was a problem hiding this comment.
@type is deprecated, we shouldn't rely on this. If the problem exists it probably applies both to Styles and Tags.
There was a problem hiding this comment.
If the problem exists it probably applies both to Styles and Tags.
Actually, the problem applies only to Custom Styles. The content of the Custom Tags is one or more block elements (paragraphs, ordered lists, etc) and the line breaks are transformed during processing of those block elements. Nevertheless, fixed in f7b6b1c 😉
…with custom styles
|
@alongosz could you make a final review, we should proceed with QA for 2.5.1 |
alongosz
approved these changes
Apr 11, 2019
katarzynazawada
approved these changes
Apr 12, 2019
|
Could you merge it up? |
|
Done. |
4 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0Note for QA: This bugfix depends on #32
TODO:
$ composer fix-cs).