Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29802: Inline custom tags support #29

Merged
merged 5 commits into from
Mar 4, 2019
Merged

EZP-29802: Inline custom tags support #29

merged 5 commits into from
Mar 4, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Feb 28, 2019

Question Answer
JIRA issue EZP-30184
Bug/Improvement no
New feature yes
Target version master
BC breaks no
Tests pass ?
Doc needed yes

TODO:

  • Implement feature / fix a bug.
  • Implement tests for is_inline: true (will be done immediately as follow up).
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs changed the title EZP-30184: As an Editor I want to collapse/expand content preview EZP-29802: Inline custom tags support Feb 28, 2019
@adamwojs adamwojs marked this pull request as ready for review March 4, 2019 12:27
@@ -642,12 +642,12 @@
<!-- Nest content of Style tag in ezcontent -->
<xsl:when test="@data-eztype='style'">
<xsl:element name="ezcontent" namespace="http://docbook.org/ns/docbook">
<xsl:apply-templates/>
<xsl:apply-templates />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is neither needed nor consistent with the other calls w/o attributes.

@lserwatka lserwatka merged commit ada7f83 into master Mar 4, 2019
@lserwatka lserwatka deleted the ezp_30184 branch March 4, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants