Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29280: As an editor, I want to add anchors to RichText content #28

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Feb 11, 2019

Question Answer
JIRA issue EZP-29280
Required by ezsystems/ezplatform-admin-ui#831
Bug/Improvement no
New feature yes
Target version master
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs changed the title [WIP] EZP-29280: As an editor, I want to add anchors to RichText content EZP-29280: As an editor, I want to add anchors to RichText content Feb 12, 2019
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH xml:id seemed out of place and inconsistent (by looking e.g. at simple class attribute) which confused me a lot, but looks like this is pure DocBook thing. Accepting because of that 👍

@adamwojs
Copy link
Member Author

adamwojs commented Feb 26, 2019

PR updated with fix for the following scenario:

Anchor to image does not work.

Steps:

  1. Add image in RTE.
  2. Click on anchor icon, fill name and save.
  3. In other paragraph link to anchor.
  4. Publish.

When clicking on created link user is not pointed to anchor.

Ref: ezsystems/ezplatform-admin-ui#831 (review)

@micszo micszo self-assigned this Feb 26, 2019
@lserwatka lserwatka merged commit 294f750 into master Feb 26, 2019
@lserwatka lserwatka deleted the ezp_29280_anchors branch February 26, 2019 14:55
@micszo micszo removed their assignment Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

6 participants