-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-5048: Fixed handling nested lists with line feeds #237
Conversation
@ezsystems/php-dev-team : Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vidarl please see first my last diff comment, it contains all the suggested changes for ListLineBreaks class from other comments to make it more clear.
I believe all review comments have been addressed now. Feel free to have a final look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and validated.
Please take note that the PR requires additional line in composer.json:
"autoload": {
"psr-4": {
"App\\": "src/",
+ "Ibexa\\FieldTypeRichText\\RichText\\": "vendor/ezsystems/ezplatform-richtext/src/lib/RichText"
}
},
<itemizedList>
and<orderedList>
cannot be below<literallayout>
in richtext. It was quite hard to deal with that in XSLT, so created a php converter to deal with it after XSLT has completedTODO:
$ composer fix-cs
).