Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3526: Fixed inline custom style in block custom style #228

Merged
merged 1 commit into from
Aug 30, 2022
Merged

IBX-3526: Fixed inline custom style in block custom style #228

merged 1 commit into from
Aug 30, 2022

Conversation

dew326
Copy link
Member

@dew326 dew326 commented Aug 29, 2022

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-3526
Bug yes
New feature no
Target version 3.3
BC breaks no
Tests pass yes
Doc needed no

For QA
Please make sure this fix still works: #110

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 added the Bug Something isn't working label Aug 29, 2022
@dew326 dew326 requested review from tischsoic and lucasOsti August 29, 2022 11:33
@dew326 dew326 self-assigned this Aug 29, 2022
tomaszszopinski
tomaszszopinski approved these changes Aug 30, 2022
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 content.

@dew326 dew326 merged commit c6345c6 into 2.3 Aug 30, 2022
@dew326 dew326 deleted the custom-style-block-inline branch August 30, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tischsoic tischsoic tischsoic approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dew326 @tischsoic @lucasOsti @tomaszszopinski @alongosz