EZP-31954: add missed validation error target #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ITernovtsiy! Thank you for submitting PR. Q: Are unit tests failing here because of missing ezsystems/ezplatform-content-forms#34 changes? |
alongosz
requested changes
Oct 5, 2020
bogusez
approved these changes
Oct 6, 2020
|
@alongosz could you merge it up? |
|
Merged up to master via bfebb27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of issue with RichText XML validation fails, where fatal error displayed:
see ezsystems/ezplatform-content-forms#34
I see similar is done for Float field type
https://github.com/ezsystems/ezpublish-kernel/blob/7.5/eZ/Publish/Core/FieldType/Float/Type.php#L125
TODO:
$ composer fix-cs).