-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31772: implement custom tag link #157
Conversation
Could you please release this simple solution while more complex #112 is in progress? |
I worked on the frontend part (ezsystems/ezplatform-admin-ui#1213) and I assume your solution will work in a similar way. This will pass to the template just a string with |
@dew326 Yes, it's just a UI change. |
I think we don't plan to cover the case with displaying the content name as we wanted to keep it consistent with the regular link in AlloyEditor. The question about if we can finish our solution is more for @adamwojs. |
hm, so maybe it makes sense to include content name in regular link too? It was a helpful feature in legacy. |
I think it might be a useful feature but let's do it step by step. Firstly we have to figure out if we can finish the "complex" solution. |
Meantime we are going to make a separate bundle for this PR. |
closing, as it's released as a bundle, and there is a duplicate ticket - ezsystems/ezplatform-admin-ui#1213 |
Currently, there is no UI for "link" custom tag attribute, so admin needs manually type location id.
Also, after admin typed it manually, it's still hard to say what's the content selected and be sure there is no typo in id.
I would like UI to contain:
TODO:
$ composer fix-cs
).