Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31626: Fixed error in AlloyEditor when embed location #147

Merged
merged 1 commit into from
May 14, 2020
Merged

EZP-31626: Fixed error in AlloyEditor when embed location #147

merged 1 commit into from
May 14, 2020

Conversation

dew326
Copy link
Member

@dew326 dew326 commented May 14, 2020

Question Answer
JIRA issue EZP-31626
Bug/Improvement yes
New feature no
Target version 2.0
Tests pass yes
Doc needed no

Merge up: ezsystems/ezplatform-admin-ui#1374

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 requested review from GrabowskiM, micszo and lucasOsti May 14, 2020 11:15
@dew326 dew326 self-assigned this May 14, 2020
@dew326 dew326 force-pushed the fix-embed-ezlocation branch from 9213ceb to dd5e2c3 Compare May 14, 2020 11:16
@micszo micszo self-assigned this May 14, 2020
micszo
micszo approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine on eZ Platform EE v3.0.3 with this diff (and 1207ede).

@lserwatka lserwatka merged commit 4b368c6 into 2.0 May 14, 2020
@lserwatka lserwatka deleted the fix-embed-ezlocation branch May 14, 2020 12:28
@dew326
Copy link
Member Author

dew326 commented May 14, 2020

Merged up to master

@micszo micszo removed their assignment May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@dew326 dew326

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dew326 @micszo @lserwatka