Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31612: use custom tag choice labels #143

Merged
merged 1 commit into from
May 14, 2020

Conversation

SerheyDolgushev
Copy link
Contributor

Question Answer
JIRA issue EZP-31612
Bug/Improvement yes
New feature no
Target version 2.0
BC breaks no
Tests pass yes
Doc needed no

Steps to reproduce:

  1. Create a custom tag with choices attribute:
custom_tags:
    factbox:
        template: '@ezdesign/custom_tag/factbox.html.twig'
        icon: '/bundles/factbox/img/icons.svg'
        is_inline: false
        attributes:
            options:
                type: choice
                choices:
                    - option1
                    - option2
                default_value: option1
                required: true
  1. Create translations for choice labels:
ezrichtext.custom_tags.factbox.attributes.options.choices.option1.label: 'Option 1'
ezrichtext.custom_tags.factbox.attributes.options.choices.option2.label: 'Option 2'
  1. Open OE and insert the custom tag

Expected result:
Choice label translations will be shown

Actual result:
Choice values are shown instead of translated labels

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 requested review from GrabowskiM and lucasOsti May 4, 2020 05:28
@katarzynazawada katarzynazawada self-assigned this May 4, 2020
@SerheyDolgushev
Copy link
Contributor Author

Sorry @dew326, is there anything that prevents it from being merged?

@dew326
Copy link
Member

dew326 commented May 14, 2020

No, It's ready for merge.

@lserwatka lserwatka merged commit 400d71d into ezsystems:2.0 May 14, 2020
@lserwatka
Copy link
Member

@dew326 could you merge it up?

@dew326
Copy link
Member

dew326 commented May 14, 2020

Merged up to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants