Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing @property-read annotations to Thumbnail class #175

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Apr 6, 2021

Question Answer
JIRA issue -
Type improvement
Target eZ Platform version 3.x
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@adamwojs adamwojs added Improvement Changes not fixing or changing behavior DX labels Apr 6, 2021
@adamwojs adamwojs requested a review from a team April 6, 2021 10:34
@adamwojs adamwojs changed the base branch from master to 1.2 April 6, 2021 11:37
@adamwojs adamwojs force-pushed the added_thumnail_phpdoc branch from 602a344 to 3b5f1f6 Compare April 6, 2021 11:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit b5bf5de into 1.2 Apr 6, 2021
@adamwojs adamwojs deleted the added_thumnail_phpdoc branch April 6, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Improvement Changes not fixing or changing behavior
Development

Successfully merging this pull request may close these issues.

4 participants