Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32283: Fixed File reference storing #160

Merged
merged 7 commits into from
Mar 11, 2021
Merged

EZP-32283: Fixed File reference storing #160

merged 7 commits into from
Mar 11, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jan 14, 2021 •
edited
Loading

Question Answer
JIRA issue EZP-32283
Type bug
Target eZ Platform version v3.2
BC breaks no
Doc needed no

When storing the copied file as a field (for example when copying fields for multiple translations) external data was not updated accordingly which resulted in SQL error.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@barw4 barw4 added the Bug Something isn't working label Jan 14, 2021
@barw4 barw4 self-assigned this Jan 14, 2021
@barw4 barw4 requested a review from ViniTou January 18, 2021 09:47
alongosz
alongosz requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need integration test coverage here to avoid further regressions

@barw4
Copy link
Member Author

barw4 commented Feb 1, 2021

@alongosz integration tests have been added.

@barw4 barw4 requested a review from alongosz February 1, 2021 19:05
alongosz
alongosz requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barw4 eZ Platform 3.1 is past EOL, please rebase to 1.2

@lserwatka
Copy link
Member

Yes, we need to rebase for 3.2 and up.

@barw4 barw4 changed the base branch from 1.1 to 1.2 February 10, 2021 09:47
@barw4 barw4 force-pushed the ezp-32283-fix-binary-file-reference-storing branch from 362cd28 to 920c2ed Compare February 10, 2021 09:49
@barw4
Copy link
Member Author

barw4 commented Feb 10, 2021

Done, let's wait for the tests.

alongosz
alongosz requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be reproduced on API test case? You'd avoid some of the issues I've just encountered.
But if not, full list of remarks (tests are not working, they're silently skipped)

...re/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageGatewayTest.php Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Outdated Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Outdated Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Outdated Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Outdated Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Outdated Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Outdated Show resolved Hide resolved
...lish/Core/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageTest.php Outdated Show resolved Hide resolved
...re/FieldType/Tests/Integration/BinaryBase/BinaryBaseStorage/BinaryBaseStorageGatewayTest.php Show resolved Hide resolved
@barw4
Copy link
Member Author

barw4 commented Mar 2, 2021 •
edited
Loading

Can't this be reproduced on API test case? You'd avoid some of the issues I've just encountered.
But if not, full list of remarks (tests are not working, they're silently skipped)

@alongosz I'm not sure about tests being silently skipped, when I'm hooking up phpunit-integration-legacy.xml both of the test cases are running and passing correctly. May I know why is this suspicion coming from?

As for reproducing on API test case, I wanted to avoid that as those tests are basically the same as eZ/Publish/Core/FieldType/Tests/Integration/User/UserStorage/UserStorageGatewayTest.php tests which specifically handle storage related things.

Some remarks have been handled in 80294ce

@barw4 barw4 requested a review from alongosz March 2, 2021 16:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz
Copy link
Member

alongosz commented Mar 8, 2021

Can't this be reproduced on API test case? You'd avoid some of the issues I've just encountered.
But if not, full list of remarks (tests are not working, they're silently skipped)

@alongosz I'm not sure about tests being silently skipped, when I'm hooking up phpunit-integration-legacy.xml both of the test cases are running and passing correctly. May I know why is this suspicion coming from?

Ok, #160 (comment)

As for reproducing on API test case, I wanted to avoid that as those tests are basically the same as eZ/Publish/Core/FieldType/Tests/Integration/User/UserStorage/UserStorageGatewayTest.php tests which specifically handle storage related things.

Hmm, ok, let's not spend more time on this.

@tomaszszopinski tomaszszopinski self-assigned this Mar 10, 2021
tomaszszopinski
tomaszszopinski approved these changes Mar 11, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 3.2.5-dev with patch.

@lserwatka lserwatka merged commit cf6b77d into 1.2 Mar 11, 2021
@lserwatka lserwatka deleted the ezp-32283-fix-binary-file-reference-storing branch March 11, 2021 12:08
@lserwatka
Copy link
Member

Could you merge it up?

@barw4
Copy link
Member Author

barw4 commented Mar 11, 2021

Merged into master: 7adb433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barw4 @lserwatka @alongosz @webhdx @ViniTou @tomaszszopinski