[Tests] Added ClockMock to make time-sensitive tests more robust #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing build: https://travis-ci.org/github/ezsystems/ezplatform-http-cache/jobs/725689032
Request::create
usestime()
method under the hood to set theREQUEST_TIME
header. By using the ClockMock (as described in https://symfony.com/doc/3.4/components/phpunit_bridge.html#time-sensitive-tests) we can make sure that thetime
call inRequest
class is mocked and we're not hit by this issue againThere are 2 deprecation warnings in current tests:
I've disabled them as described in https://symfony.com/doc/3.4/components/phpunit_bridge.html#disabling-the-deprecation-helper, because I don't want to introduce too many changes here.
(1) In 2.1 and master the whole request is not compared:
https://github.com/ezsystems/ezplatform-http-cache/blob/2.1/tests/PurgeClient/LocalPurgeClientTest.php
so the test is not time-sensitive, but I think we can keep the dependency for future usages.
TODO:
$ composer test
)$ composer fix-cs
).