EZP-24765: Give possibility to set additional paths for a given theme #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @andrerom @bdunogier |
andrerom
approved these changes
Jun 15, 2017
doc/templates.md
Outdated
| template_theme_paths: | ||
| # FOSUserBundle templates will be part of "my_theme" theme | ||
| my_theme: | ||
| - '%kernel.root_dir%/../vendor/friendsofsymfony/user-bundle/Resources/views' |
There was a problem hiding this comment.
On sf 3.3 there is also kernel.project_dir, but doesn't make much of a differance here.
There was a problem hiding this comment.
I was tempted to use %kernel.project_dir% but as we don't require Symfony 3.3 yet, I preferred using the old fashion way 😛
bdunogier
requested changes
Jun 16, 2017
| ->arrayNode('template_theme_paths') | ||
| ->useAttributeAsKey('theme') | ||
| ->example(['some_theme' => ['/var/foo/some_theme_dir', '/another/theme/dir']]) | ||
| ->info('Collection of template paths by theme.') |
There was a problem hiding this comment.
Actually, I'd make templates plural, and update the setting name. I know we've spent time on it, but it sounds wrong now :)
Funnily enough, it is reversed in the container parameter's name: ezdesign.templates_path_map 😉
doc/templates.md
Outdated
| @@ -41,6 +41,25 @@ Default fallback order is the following: | |||
|
|
|||
| > Bundle fallback order is the instantiation order in `AppKernel`. | |||
|
|
|||
| ### Additional theme paths | |||
| In addition to the convention described above, it is also possible to add arbitrary Twig template directories to a theme | |||
lolautruche
force-pushed
the
feat/configuredThemePaths
branch
from
93e15f6 to
823b2ff
Compare
> https://jira.ez.no/browse/EZP-27465 This patch makes it possible to add arbitrary Twig template directories to a theme from configuration. This can be useful when you want to define templates from third-party bundles as part of one of your themes, or when upgrading your application in order to use eZ Platform design engine, and that your existing templates are not yet following the convention. Practical use case would be to define a `standard` theme for templates provided by the kernel. ```yaml ezdesign: design_list: my_design: [my_theme, some_other_theme] templates_theme_paths: # FOSUserBundle templates will be part of "my_theme" theme my_theme: - '%kernel.root_dir%/../vendor/friendsofsymfony/user-bundle/Resources/views' ```
lolautruche
force-pushed
the
feat/configuredThemePaths
branch
from
823b2ff to
d2eb415
Compare
|
@bdunogier Fixed |
|
@bdunogier ping ? 😃 |
bdunogier
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it possible to add arbitrary Twig template directories to a theme from configuration.
This can be useful when you want to define templates from third-party bundles as part of one of your themes, or when upgrading your application in order to use eZ Platform design engine, and that your existing templates are not yet following the convention.
Practical use case would be to define a
standardtheme for templates provided by the kernel.