[EZP-27715] Fix check for wrong definition in TwigThemePass #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TwigThemePass` is added at the `PassConfig::TYPE_OPTIMIZE` step, so `twig.loader.filesystem` may have already been removed (private service, may be inlined so service definition may not exist any more).
andrerom
approved these changes
Jul 27, 2017
bdunogier
approved these changes
Jul 27, 2017
|
Merging to master. We can still tag it as a 1.0.x, since no features were added to master since 1.0. |
|
Thanks Indeed a 1.0.1 would be great |
|
Please create a JIRA issue for it, so that we can send it to QA, and have the thing tested before we tag it. Could you please describe in the JIRA issue how the bug can be triggered ? |
lolautruche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TwigThemePassis added at thePassConfig::TYPE_OPTIMIZEstep, sotwig.loader.filesystemmay have already been removed (private service, may be inlined so service definition may not exist any more).
Also fixed in
lolautruche/ez-core-extra-bundle