Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] Changed assertions removed in PHPUnit 10 #2086

Merged
merged 1 commit into from
Feb 6, 2023
Merged

[Behat] Changed assertions removed in PHPUnit 10 #2086

merged 1 commit into from
Feb 6, 2023

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Feb 6, 2023 •
edited
Loading

Failing tests:

       | ezobjectrelation     | Content relation (single)    | Images       | Media/Images       | Media             | value     | Media/Images  |            |               | Media        |              |
        Failed step: Then I should see correct data for the right side comparison
        Behat\Testwork\Call\Exception\FatalThrowableError: Fatal error: Call to undefined method PHPUnit\Framework\Assert::assertRegExp() in vendor/ezsystems/ezplatform-admin-ui/src/lib/Behat/Component/Fields/ContentRelationSingle.php:101

(https://github.com/ibexa/commerce/actions/runs/4102522082/jobs/7077909870)

assertRegExp has been removed in PHPUnit 10, assertMatchesRegularExpression should be used instead

See: sebastianbergmann/phpunit#4087
Tested in ibexa/commerce#211

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnocon mnocon marked this pull request as ready for review February 6, 2023 14:19
@mnocon mnocon mentioned this pull request Feb 6, 2023
Merged
bogusez
bogusez approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@bogusez bogusez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@micszo micszo merged commit d2c9072 into 2.3 Feb 6, 2023
@micszo micszo deleted the phpunit10-deprecation branch February 6, 2023 15:00
@mnocon mnocon mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@micszo micszo micszo approved these changes

@jwibexa jwibexa Awaiting requested review from jwibexa

@katarzynazawada katarzynazawada Awaiting requested review from katarzynazawada

@tomaszszopinski tomaszszopinski Awaiting requested review from tomaszszopinski

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnocon @micszo @bogusez @mikadamczyk @Nattfarinn