IBX-824: Fixed triggering closing link popup on formatted text #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Aug 25, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
3 tasks
lucasOsti
approved these changes
Aug 26, 2021
kacper-wieczorek-ibexa
approved these changes
Aug 27, 2021
|
You can merge it up now. |
lserwatka
deleted the
ibx-824-trigger-link-popup-close-on-formatted-text
branch
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that text formatted with bold, italic, or underline doesn't trigger popup closing after adding a link. I added proper condition ensuring that and implemented a method for moving the caret to the end of the text element. This aims to preserve the consistency with the behavior observed for the non-formatted text when the link is associated. Otherwise, the caret will be moved to the beginning of bold/italic/underline each time which might be inconvenient for the editors.
PR targetting v3 will be done once this solution gets approval.
Checklist:
$ composer fix-cs)