Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3465: Made SiteaccessPreviewVoter repository aware #1704

Closed
wants to merge 12 commits into from
Closed

EZEE-3465: Made SiteaccessPreviewVoter repository aware #1704

wants to merge 12 commits into from

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Feb 4, 2021 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/EZEE-3465
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

As the title states.

Required ezpublish-kernel PR: ezsystems/ezpublish-kernel#3085

Regression suite: https://github.com/ezsystems/ezplatform-page-builder/pull/726

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 added the Bug label Feb 4, 2021
@barw4 barw4 self-assigned this Feb 4, 2021
@barw4 barw4 changed the base branch from master to 1.5 February 4, 2021 09:33
@barw4 barw4 mentioned this pull request Feb 4, 2021
Merged
4 tasks
@barw4 barw4 requested a review from a team February 4, 2021 11:13
adamwojs
adamwojs reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update/provide tests for AbstractSiteaccessPreviewVoter?

src/lib/Siteaccess/AbstractSiteaccessPreviewVoter.php Outdated Show resolved Hide resolved
@barw4 barw4 requested a review from adamwojs February 8, 2021 14:12
@barw4
Copy link
Member Author

barw4 commented Feb 8, 2021

@adamwojs Tests have been added in d06f819

@micszo micszo self-assigned this Feb 10, 2021
@barw4 barw4 mentioned this pull request Feb 11, 2021
Merged
2 tasks
@barw4
Copy link
Member Author

barw4 commented Feb 11, 2021

Closed in favor of #1706

@barw4 barw4 closed this Feb 11, 2021
@micszo micszo removed their assignment Feb 11, 2021
@adamwojs adamwojs deleted the ezee-3465-sa-voter-repo-aware branch February 12, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p left review comments

@adamwojs adamwojs adamwojs approved these changes

Assignees

@barw4 barw4

Labels
Bug Ready for QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @adamwojs @Steveb-p @micszo @mikadamczyk