Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: EZP-23878 No result when I found 1 location in several languages wi... #187

Merged
merged 1 commit into from
May 17, 2015

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Jan 12, 2015

...th multicore ezfind

JIRA: https://jira.ez.no/browse/EZP-23878

@andrerom
Copy link
Contributor

+0,5, review ping @yannickroger @paulborgermans

@bdunogier
Copy link
Member

+1

@yannickroger
Copy link
Contributor

It seems that your fix prevents the code from breaking later, could you explain your fix a bit more ?

@blankse
Copy link
Contributor Author

blankse commented Jan 12, 2015

In this case the $localNodeIDList variable is an array with several of the same IDs.

e.g. array( 123, 123, 123 )

The eZContentObjectTreeNode::fetch function gets only a node instead of a node list. (Line: https://github.com/blankse/ezfind/blob/patch-1/search/plugins/ezsolr/ezsolr.php#L1625)

The if-statement fails because the $localNodeIDList have more than one elements (Line: https://github.com/blankse/ezfind/blob/patch-1/search/plugins/ezsolr/ezsolr.php#L1627)

It is also possible to change the if-statement to following:

if ( isset( $tmpNodeRowList['node_id'] ) )

@yannickroger
Copy link
Contributor

+1 then.
ping @paulborgermans

@blankse
Copy link
Contributor Author

blankse commented Jan 23, 2015

ping @paulborgermans

1 similar comment
@blankse
Copy link
Contributor Author

blankse commented May 14, 2015

ping @paulborgermans

@paulborgermans
Copy link
Contributor

+1, sorry for late review

andrerom added a commit that referenced this pull request May 17, 2015
Fix: EZP-23878 No result when I found 1 location in several languages wi...
@andrerom andrerom merged commit 09ae480 into ezsystems:master May 17, 2015
@blankse blankse deleted the patch-1 branch May 18, 2015 12:53
@andrerom
Copy link
Contributor

@blankse Could you provide some feedback to QA in the issue on how this is reproduced? Seems to need some more info :)

@pcardiga
Copy link

ping @blankse QA is unable to reproduce this issue. Can you please provide the steps to reproduce in the issue? Thanks

@ghost
Copy link

ghost commented May 29, 2015

@blankse, I'm Rui Silva from the QA team. We are trying to reproduce the issue with the description provided but the info there doesn't seem enough to know how to proceed with reproducing it.
Can you please describe onto further detail the steps taken to reproduce it?
Thanks.

@andrerom
Copy link
Contributor

I don't think it helps contacting him once per day, if he is not answering he is probably busy.

@paulborgermans Do you happen to know how this can be reproduced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants