-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: EZP-23878 No result when I found 1 location in several languages wi... #187
Conversation
… with multicore ezfind
+0,5, review ping @yannickroger @paulborgermans |
+1 |
It seems that your fix prevents the code from breaking later, could you explain your fix a bit more ? |
In this case the $localNodeIDList variable is an array with several of the same IDs.
The eZContentObjectTreeNode::fetch function gets only a node instead of a node list. (Line: https://github.com/blankse/ezfind/blob/patch-1/search/plugins/ezsolr/ezsolr.php#L1625) The if-statement fails because the $localNodeIDList have more than one elements (Line: https://github.com/blankse/ezfind/blob/patch-1/search/plugins/ezsolr/ezsolr.php#L1627) It is also possible to change the if-statement to following:
|
+1 then. |
ping @paulborgermans |
1 similar comment
ping @paulborgermans |
+1, sorry for late review |
Fix: EZP-23878 No result when I found 1 location in several languages wi...
@blankse Could you provide some feedback to QA in the issue on how this is reproduced? Seems to need some more info :) |
ping @blankse QA is unable to reproduce this issue. Can you please provide the steps to reproduce in the issue? Thanks |
@blankse, I'm Rui Silva from the QA team. We are trying to reproduce the issue with the description provided but the info there doesn't seem enough to know how to proceed with reproducing it. |
I don't think it helps contacting him once per day, if he is not answering he is probably busy. @paulborgermans Do you happen to know how this can be reproduced? |
...th multicore ezfind
JIRA: https://jira.ez.no/browse/EZP-23878