do not touch database if not asked when choosing ezdemo_site_clean package

[crevillo]

This pull request tries to solve a problem when installing legacy bridge on top of ezplatform and you select ezdemo_site_clean as package.

When executing the setup there is a step asking you what to do with the database. One of the options is ' Leave the data and do nothing, but when ezdemo_site_clean is choosen, this is not honoured and the installer tries to execute some sql scripts. t

As those scripts try to create tables and indexes that are already in the db, it fails and installation cannot end.

The patch is the same as e11f15c

Funnily enough, git blame says i am the creator of that patch but i didn't rememeber it ☺️

Let me know if you want me to create a ticket for this or is this pr is enough.

[crevillo]

ping @bdunogier @andrerom
p.s. should i ping other people if i p.r to this repo? thanks.

[andrerom]

p.s. should i ping other people if i p.r to this repo? thanks.

afaik no, as this repo is kind of not maintained atm, it could be if someone wants to. But for new projects you ideally should rather use platform installers, and somehow generate legacy config if you still rely on legacy for admin part (which imo is not needed anymore for 99% of projects next year with v2, but that another discussion)

There is POC PR on legacy bridge for exposing legacy friendly clean install option (swap RichText content for XMLText basically). This needs some cleanup, but once that is done this install could also for instance generate legacy config based on what has been configured in platform, afaik @emodric has some raw twig based templates for legacy settings that can be used as basis for something like this.

[crevillo]

ok, good to know. yeah, our plan is avoid legacy if possible. this was merely a test i was doing and i find that issue.