Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-827 Moving Jobs on 1.0 ez-support-tools #106

Merged
merged 6 commits into from
Oct 11, 2021
Merged

IBX-827 Moving Jobs on 1.0 ez-support-tools #106

merged 6 commits into from
Oct 11, 2021

Conversation

kacper-wieczorek-ibexa
Copy link
Contributor

No description provided.

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa marked this pull request as ready for review September 27, 2021 10:04
mnocon
mnocon requested changes Sep 27, 2021
View reviewed changes
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests execution to Github Actions (only CS is executed right now).

After it's done we can get rid of the Travis configuration, because all of the jobs will be on Github Actions (only CS and Unit tests are on this branch).

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa force-pushed the IBX-827_Moving_jobs_1.0_ez-support-tools branch from 6a9d406 to 3d0301d Compare September 27, 2021 11:10
mnocon
mnocon reviewed Oct 5, 2021
View reviewed changes
.github/workflows/ci.yaml Outdated
with:
php-version: ${{ matrix.php }}
coverage: none
extensions: redis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this different than the standard value in the template (extensions: pdo_sqlite, gd), what difference does it make?

@kacper-wieczorek-ibexa
Update ci.yaml
2a2523e 
Correction in ci.yaml
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Steveb-p
Steveb-p requested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML indentation is incorrect. It should be 4 spaces.

@Steveb-p Steveb-p merged commit edd1dd1 into 1.0 Oct 11, 2021
@Steveb-p Steveb-p deleted the IBX-827_Moving_jobs_1.0_ez-support-tools branch October 11, 2021 09:42
@Steveb-p
Copy link
Contributor

@mnocon during merge up I've noticed that there are behat tests upstream, which would be removed by the change. Therefore master branch probably requires your attention.

@mnocon
Copy link
Member

mnocon commented Oct 11, 2021

@Steveb-p I've merged this PR upstream (1.0 -> 2.3 -> master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@mnocon mnocon mnocon approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@micszo micszo Awaiting requested review from micszo

@piotrbisaga piotrbisaga Awaiting requested review from piotrbisaga

@tomaszszopinski tomaszszopinski Awaiting requested review from tomaszszopinski

Assignees

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa

Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kacper-wieczorek-ibexa @Steveb-p @mnocon @bogusez