[WIP] Test PlatformUI PR #901
Conversation
If I understand that correctly, the spinner appears, disappears and reappears while things are still loading and you are trying to workaround that, right ? But isn't that behavior a bug ? I mean I find it weird to workaround a bug in a code that is suppose (among other things) to avoid bugs. Can't this bug be fixed ? |
|
About the bug: at first I thought so too, but as far as I know this behaviour is not that easy to fix and wasn't prioritised as high to be worth the effort. It's not that the spinner behaviour got worse all of a sudden - we've changed the test driver and the new driver sometimes behaves in a different way than the previous one. On a different note': your comment made me realise that there is also another option to try, I will try to change this solution. About the test failure: at first I thought that I should be able to reproduce it locally, as it the same error that enforced this change: https://github.com/ezsystems/ezplatform/blob/master/doc/docker/selenium.yml#L16 Still, I suspect that changing it to 256m might help - I'll test it in ezsystems/ezplatform#211 |
|
Tool version : PHP CS Fixer 2.1.2 by Fabien Potencier and Dariusz Ruminski diff --git a/Features/Context/SubContext/Authentication.php b/Features/Context/SubContext/Authentication.php
index 12dbb95..c3c93ce 100644
--- a/Features/Context/SubContext/Authentication.php
+++ b/Features/Context/SubContext/Authentication.php
@@ -24,7 +24,7 @@ trait Authentication
public function goToPlatformUi($url = '')
{
$this->visit($this->platformUiUri . $url);
- $this->waitWhileLoading();
+ $this->waitWhileLoading();
}
/**
@@ -63,7 +63,7 @@ trait Authentication
public function iLogout()
{
$this->shouldBeLoggedIn = false;
- $this->waitWhileLoading();
+ $this->waitWhileLoading();
$this->goToPlatformUi('#/dashboard');
$el = $this->findWithWait('.ez-user-profile');
$el->focus(); |
mnocon
changed the title
Do not merge
The previously suggested changes are not needed, increasing shm size should do the trick.:
ezsystems/ezplatform#214
This is something similar to the problem that occured in #895:When elements overlap Chrome driver reacts differently than Firefox. It tries to click the spinner and fails with UnknownError exception:This time the issue occurs in various places and is involved with the spinner visible when application is reloading.Screen of example failure:
The selector to detect the spinner is still correct, I suspect Chrome driver is more prone to the spinner "blinking" (disappearing and appearing again in very short time) - it can be seen in the Studio part.I've considered various solutions:- Overriding the click method to catch the Exception, wait some time and then try again feels like an overkill.- Different selectors for the spinner also did not help, as the selector is correct (and it really disappears for a moment).My approach requires multiple checks in a row to pass in order to decide, that the spinner is indeed gone. It's a simple solution, but has some drawbacks:- there's still a chance that a test will fail (hopefully it's low - I've chosen the $consecutiveTimesRequired by hand and it looks stable)- every waitWhileLoading execution will execute at least 3 sleeps instead of 1 (one sleep is 250 ms).Execution times before and after, based on StudioUI common suite:Before; 42 min 23 secAfter: 45 min 52 secI think it's acceptable, at least for now.