Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-2313: [eZ Reco] Session ID is empty when Symfony AuthenticationGuard is used #116

Merged
merged 1 commit into from
Sep 12, 2018
Merged

EZEE-2313: [eZ Reco] Session ID is empty when Symfony AuthenticationGuard is used #116

merged 1 commit into from
Sep 12, 2018

Conversation

kmadejski
Copy link
Member

Question Answer
JIRA issue EZEE-2313
Bug yes
New feature no

This PR introduces additional session isStarted check which is necessary in case of using Symfony AuthenticationGuard(s).

@kmadejski kmadejski mentioned this pull request Sep 7, 2018
Merged
andrerom
andrerom approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but rebase once travis change is merged for travis pass please :)

@kmadejski kmadejski merged commit 361537c into ezsystems:2.2 Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianz5 damianz5 damianz5 approved these changes

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmadejski @andrerom @damianz5