Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapted clearing persistence tags after the refactoring #211

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Adapted clearing persistence tags after the refactoring #211

merged 1 commit into from
Sep 16, 2021

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Sep 15, 2021 •
edited
Loading

Failing build: https://app.travis-ci.com/github/ezsystems/ezplatform/jobs/537291945

Error:

        Exception: Could not load the Content type after publishing. in vendor/ezsystems/behatbundle/EzSystems/BehatBundle/API/Facade/ContentTypeFacade.php:92
        Stack trace:
        #0 vendor/ezsystems/behatbundle/EzSystems/BehatBundle/API/Facade/ContentTypeFacade.php(49): EzSystems\BehatBundle\API\Facade\ContentTypeFacade->assertContentTypeExistsInGroup()

In ezsystems/ezpublish-kernel#3114 the persistance tags have been changed and since then the Content Type cache purge no longer works.

I've adapted the code based on what's in the kernel.

Old code:
https://github.com/ezsystems/ezpublish-kernel/blob/v7.5.21/eZ/Publish/Core/Persistence/Cache/ContentTypeHandler.php#L272-L287

Current code:
https://github.com/ezsystems/ezpublish-kernel/blob/7abf76039ab3c7395b8ff4d0cda420ebe0c4324c/eZ/Publish/Core/Persistence/Cache/ContentTypeHandler.php#L316-L335

@mnocon mnocon force-pushed the adapt-to-the-tags branch 2 times, most recently from 59670e6 to ba50c07 Compare September 15, 2021 11:16
@mnocon mnocon marked this pull request as ready for review September 15, 2021 15:04
@mnocon mnocon changed the title Adapted clearing persistance tags after the refactoring Adapted clearing persistence tags after the refactoring Sep 16, 2021
@micszo
Copy link
Member

micszo commented Sep 16, 2021

FYI @konradoboza

micszo
micszo approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@micszo micszo merged commit 302fee9 into 7.0 Sep 16, 2021
@micszo micszo deleted the adapt-to-the-tags branch September 16, 2021 08:54
@konradoboza konradoboza mentioned this pull request Oct 20, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@micszo micszo micszo approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa Awaiting requested review from kacper-wieczorek-ibexa

@piotrbisaga piotrbisaga Awaiting requested review from piotrbisaga

Assignees
No one assigned
Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnocon @micszo @tomaszszopinski @bogusez