Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build for more platforms and compilers #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chansuke
Copy link

#23
Add minimum compiler version & 32-bit support

@joshlf
Copy link
Collaborator

joshlf commented Sep 14, 2017

Thanks for the PR, and welcome!

Looks good except for one thing: can you squash into a single commit and make the commit message something like Travis: Add minimum support Rust version and 32-bit support?

@chansuke
Copy link
Author

@joshlf Thank you for the comment!!OK.

@chansuke chansuke force-pushed the build-for-more-platforms-and-compilers branch from d2aa0b6 to 9289540 Compare September 14, 2017 17:23
@joshlf
Copy link
Collaborator

joshlf commented Sep 15, 2017

So the Travis builds are failing for reasons that they weren't failing before. Can you take a look at those and make appropriate fixes?

@chansuke
Copy link
Author

@joshlf I'll fix it.

@chansuke chansuke force-pushed the build-for-more-platforms-and-compilers branch from 9289540 to 029024e Compare September 15, 2017 17:26
@joshlf
Copy link
Collaborator

joshlf commented Sep 15, 2017

Still getting the same error on some builds, e.g. https://travis-ci.org/ezrosent/allocators-rs/jobs/275984270

@chansuke
Copy link
Author

@joshlf Sorry about that.I've checked and fixed errors but another error(error: Could not compile bagpipe) occurs in some of environment.
error_remains

@joshlf
Copy link
Collaborator

joshlf commented Sep 17, 2017

Hmm OK, I'll take a look. Might have to do with a bug we just uncovered elsewhere, so we might have to fix that first and then rebase those changes into this PR.

@joshlf
Copy link
Collaborator

joshlf commented Sep 17, 2017

Hmm I'm not sure what's going on. For example, on Linux/Rust nightly, elfmalloc's tests are resulting in a SIGKILL getting sent to the test process. I'm not sure what that's about.

@chansuke chansuke force-pushed the build-for-more-platforms-and-compilers branch from 029024e to 10e9382 Compare September 18, 2017 07:16
@chansuke
Copy link
Author

@joshlf
I've pushed it but I couldn't figure out the Could not compile bagpipe error.

@joshlf
Copy link
Collaborator

joshlf commented Sep 18, 2017

Every one of the builds is now failing with the error no $ARCH specified. Are you sure you're clicking on the new builds and not just re-loading an old build from one of your previous commits? Click on the Travis CI "Details" link in the checks dialogue at the bottom of this page.

@joshlf
Copy link
Collaborator

joshlf commented Sep 19, 2017

Also, we found the source of the bsalloc compilation issue. We're going to have to wait for this PR to land in lazy_static: rust-lang-nursery/lazy-static.rs#84

@chansuke
Copy link
Author

@joshlf Ok.Thank you for the information.

@joshlf
Copy link
Collaborator

joshlf commented Sep 28, 2017

OK, lazy_static has pushed a new version, and I've merged a change to use that version. If you pull the latest version of master and then rebase master into this branch, we should be good to go.

@joshlf joshlf changed the title Build for more platforms and compilers CI: Build for more platforms and compilers Dec 7, 2017
@joshlf
Copy link
Collaborator

joshlf commented Dec 7, 2017

Moved to #135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants