Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-scripts: Optimize check-copyright-comments.sh #189

Open
joshlf opened this issue Jul 1, 2018 · 1 comment
Open

test-scripts: Optimize check-copyright-comments.sh #189

joshlf opened this issue Jul 1, 2018 · 1 comment

Comments

@joshlf
Copy link
Collaborator

joshlf commented Jul 1, 2018

The test-scripts/check-copyright-comments.sh script is run as a git hook, and currently, it is slow enough that it meaningfully impacts the speed of running git commit or git rebase. We should either optimize it or provide an alternative script written in a faster language (e.g., Python) that we can use when support is available on the local platform.

joshlf added a commit that referenced this issue Jul 1, 2018
- Go from ~10.6s to ~4.1s.

Partially addresses #189
joshlf added a commit that referenced this issue Jul 1, 2018
- Go from ~10.6s to ~4.1s.

Partially addresses #189
@joshlf
Copy link
Collaborator Author

joshlf commented Jul 1, 2018

#190 Brings the execution duration from ~10.6s to ~4.1s. It's unclear how much more opportunity for optimization there is, since the majority of that time is taken in a single necessary git log call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant